Lazy loading through AST-mapped public API#62
Draft
Helveg wants to merge 1 commit intopip-v-cmake-buildfrom
Draft
Lazy loading through AST-mapped public API#62Helveg wants to merge 1 commit intopip-v-cmake-buildfrom
Helveg wants to merge 1 commit intopip-v-cmake-buildfrom
Conversation
|
Pull request automatically marked stale! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For user convenience pretty much every module is eager loaded onto the core NEST module. This has led to circular dependencies, code execution at import time, and long import times (about 1s for me).
Using the AST module we can scan all
.pyfiles for a module level__all__declaration, and filter out the explicitly declared parts of the public API. We can then replace all dynamic module magic of thenestmodule by a fully spec-supported__getattr__approach that loads modules as attributes are requested.On my slow IO WSL it improved import times from 1s to 0.04s. On native Linux boxes an initial test showed that it would be more like a 0.8s to 8e-05 reduction of
import nest